Update Butler's gulp-sass requirement to work with yarn #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfweston
changed the title
patrickfweston
changed the title
|
This is not critical, but I run butler on Argonne with this update I'm now getting a lot of these warnings:
I believe mixins in singularity and posscss that are using call() are triggering this. We should see if they are updated to fix this in newer versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While
yarnmay be run locally to compile styleguides, many of our deployment processes rely on building the styleguide prior to deployment. Therefore, when runningphing buildafter upgrading a project toyarn, the styleguide is not built and the freshest CSS/JS is not deployed.Description
The current version of
gulp-sassthat we are using relies on a version ofnode-sassthat has no compiled binaries for Linux. When running this from inside of Vagrant, errors are thrown asyarnattempts to buildnode-sassfrom source. It cannot build from source becausenode-sass3.13.1 only supports down to node 7.yarnrequires node 9+. As a result, it is impossible to runyarnfrom within Vagrant.Solution
The solution is simple: change the dependency in Butler to use a newer version of
gulp-sass(which therefore requires a newer version ofnode-sass). The latest versions support node 9 (and thereforeyarn).To test
node_modules/folderyarnfrom thestyleguide/directory in a projectyarn run butler. It should serve the styleguide.